repl: fix /dev/null history file regression #12762
Merged
+20
−16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
addaleax
approved these changes
Apr 30, 2017
Fishrock123
approved these changes
Apr 30, 2017
| @@ -178,6 +179,21 @@ const tests = [ | |||
| test: [UP], | |||
| expected: [prompt] | |||
| }, | |||
| { | |||
| before: function before() { | |||
| if (!common.isWindows) { | |||
There was a problem hiding this comment.
This test case passes on Windows?
There was a problem hiding this comment.
Yes, because like the test case before it, it will just act like an empty file on other platforms.
Fishrock123
reviewed
Apr 30, 2017
| } | ||
| } | ||
| }, | ||
| env: { NODE_REPL_HISTORY: devNullHistoryPath }, |
There was a problem hiding this comment.
Wait, you can't just set this to /dev/null?
There was a problem hiding this comment.
No, because I believe Windows would then fail since /dev/null does not exists there and currently there is no way to conditionally skip a test from running, you can only make it fall back to the empty history file scenario.
cjihrig
approved these changes
Apr 30, 2017
mscdex
force-pushed
the
repl-history-regression
branch
2 times, most recently
from
025b12c
to
24326a0
Compare
|
I've made a slight tweak to the test so that it creates the symlink in a more appropriate place now (the temp dir. instead of fixtures). CI once again: https://ci.nodejs.org/job/node-test-pull-request/7791/ |
bzoz
approved these changes
May 2, 2017
Fishrock123
approved these changes
May 2, 2017
jasnell
approved these changes
May 2, 2017
This fixes a regression from 83887f3 where ftruncate() fails on a file symlinked to /dev/null. PR-URL: nodejs#12762 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Bartosz Sosnowski <bartosz@janeasystems.com> Reviewed-By: James M Snell <jasnell@gmail.com>
mscdex
force-pushed
the
repl-history-regression
branch
from
24326a0
to
c20e87a
Compare
anchnk
pushed a commit
to anchnk/node
that referenced
this pull request
May 6, 2017
This fixes a regression from 83887f3 where ftruncate() fails on a file symlinked to /dev/null. PR-URL: nodejs#12762 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Bartosz Sosnowski <bartosz@janeasystems.com> Reviewed-By: James M Snell <jasnell@gmail.com>
|
I just noticed that the problematic commit made its way into v7.x without this fix :-(, so I've updated the tags accordingly to match that of the PR for that commit. |
3 tasks
3 tasks
gibfahn
pushed a commit
that referenced
this pull request
Jun 18, 2017
This fixes a regression from 83887f3 where ftruncate() fails on a file symlinked to /dev/null. PR-URL: #12762 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Bartosz Sosnowski <bartosz@janeasystems.com> Reviewed-By: James M Snell <jasnell@gmail.com>
gibfahn
pushed a commit
that referenced
this pull request
Jun 20, 2017
This fixes a regression from 83887f3 where ftruncate() fails on a file symlinked to /dev/null. PR-URL: #12762 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Bartosz Sosnowski <bartosz@janeasystems.com> Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins
pushed a commit
that referenced
this pull request
Jul 11, 2017
This fixes a regression from 83887f3 where ftruncate() fails on a file symlinked to /dev/null. PR-URL: #12762 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Bartosz Sosnowski <bartosz@janeasystems.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a regression from bb041ea where
ftruncate()fails on a file symlinked to /dev/null./cc @bzoz @jasnell
CI: https://ci.nodejs.org/job/node-test-pull-request/7761/
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)